mafoo.org.uk/selfdefined
1
0
Fork 0
mirror of https://github.com/fooflington/selfdefined.git synced 2025-06-10 21:01:41 +00:00
Code Issues Projects Releases Wiki Activity

Style fixes (#144)

Browse Source 
* change "title__thicc" classname to "title--thicc" to reflect BEM naming convention

* fix indentation in index.njk

* add vertical spacing between homepage sections

* convert ".help" class to ".box__list" class

CSS classes generally shouldn't be related to content

* remove duplicate code for .page

* change auto-grid class to "auto-fit", from "auto-fill"

This reduces unused negative space on screens between 800-1200px wide

* use proper BEM practice - block, then modifier class

* refactor .flag styles to be more BEM

* add BEM block-level class to h1

* refactor box__list to simply "list"

* It will be its own component rather than element of the "box" block

* Remove duplicate (older) thicc styles from _header.scss

* rename .title--thicc to .thicc-headline to be more consistent with other "headline" heading classes

* rename another .title--thicc -> .thicc-headline

* refactor CSS selector from adjacent to class

* refactor the whole header to separate grid layout and typography

* remove unneeded grid style

* it's not a grid item

* remove sub-headline typography from _header.scss and add it to _typography.scss

* remove horizontal margin from box below tablet size

* noticed that the .box class, which is already squished on 320px wide screens, is more squished because of its margins.

* allow headings to wrap if necessary

noticed that headings (e.g. "development and build") were blowing out the grid on small screens and causing horizontal scroll

* rename subtitle to "sub-headline"

* convert <section> to <header>

makes more semantic sense for a screen-reader, since this really is the header of the document.

* discard heading wrapper element in favour of having just the heading element

Co-authored-by: Oscar <ovlb@users.noreply.github.com>
This commit is contained in:
Bashu Naimi-Roy
2020-05-28 04:01:04 -04:00
committed by GitHub
parent ba43ece075
commit 941403694a
11 changed files with 88 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
assets/css/base/_helpers.scss
View File

@ -10,13 +10,6 @@
font-style: italic;
}
.help {
margin: 1rem 0;
li {
margin: 0.75rem 0;
}
}
.visually-hidden {
clip: rect(0 0 0 0);
clip-path: inset(100%);

30
assets/css/base/_typography.scss
View File

@ -9,6 +9,7 @@ h3,
h4 {
margin-bottom: 0.5em;
margin-top: 1em;
word-break: break-word;
}
p {
@ -17,42 +18,31 @@ p {
margin: 0.75rem 0;
}
.title__thicc {
.thicc-headline {
// a sensible base font size
font-size: 3rem;
line-height: 0.75;
margin: 0.5rem 0rem;
padding: 0;
// transform: rotateZ(90deg);
// margin: 13rem -7rem;
}
@media (min-width: 51rem) and (min-height: 400px) {
// a dramatic font size
.title__thicc {
.thicc-headline {
font-size: 12vh;
}
}
@media (min-width: 51rem) and (min-height: 850px) {
// cap the max-height of the title
// cap the maximum font size of the title
// at the same size that 12vh computes to
// when the viewport is 850px high
.title__thicc {
// One day we can use CSS clamp https://caniuse.com/#feat=mdn-css_types_clamp
.thicc-headline {
font-size: 6.75rem;
}
}
@media (min-width: 800px) {
.title__thicc {
grid-column: 1 / 3;
}
.title__thicc + p {
grid-column: 1 / 2;
}
}
.main-headline {
font-family: orpheuspro, Palatino, Times, serif;
font-size: 3.5rem;
@ -60,11 +50,15 @@ p {
margin: 0;
}
.subtitle {
.sub-headline {
font-size: 1.25rem;
font-weight: bold;
}
.sub-headline {
font-family: $ext-sans;
font-size: 1.25rem;
font-weight: $regular;
grid-column: span 2;
letter-spacing: 0.1;
margin: .75rem 0;
}