mafoo.org.uk/selfdefined
1
0
Fork 0
mirror of https://github.com/fooflington/selfdefined.git synced 2025-06-10 21:01:41 +00:00
Code Issues Projects Releases Wiki Activity

Style fixes (#144)

Browse Source 
* change "title__thicc" classname to "title--thicc" to reflect BEM naming convention

* fix indentation in index.njk

* add vertical spacing between homepage sections

* convert ".help" class to ".box__list" class

CSS classes generally shouldn't be related to content

* remove duplicate code for .page

* change auto-grid class to "auto-fit", from "auto-fill"

This reduces unused negative space on screens between 800-1200px wide

* use proper BEM practice - block, then modifier class

* refactor .flag styles to be more BEM

* add BEM block-level class to h1

* refactor box__list to simply "list"

* It will be its own component rather than element of the "box" block

* Remove duplicate (older) thicc styles from _header.scss

* rename .title--thicc to .thicc-headline to be more consistent with other "headline" heading classes

* rename another .title--thicc -> .thicc-headline

* refactor CSS selector from adjacent to class

* refactor the whole header to separate grid layout and typography

* remove unneeded grid style

* it's not a grid item

* remove sub-headline typography from _header.scss and add it to _typography.scss

* remove horizontal margin from box below tablet size

* noticed that the .box class, which is already squished on 320px wide screens, is more squished because of its margins.

* allow headings to wrap if necessary

noticed that headings (e.g. "development and build") were blowing out the grid on small screens and causing horizontal scroll

* rename subtitle to "sub-headline"

* convert <section> to <header>

makes more semantic sense for a screen-reader, since this really is the header of the document.

* discard heading wrapper element in favour of having just the heading element

Co-authored-by: Oscar <ovlb@users.noreply.github.com>
This commit is contained in:
Bashu Naimi-Roy
2020-05-28 04:01:04 -04:00
committed by GitHub
parent ba43ece075
commit 941403694a
11 changed files with 88 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
assets/css/components/_flag.scss
View File

@ -1,5 +1,4 @@
.flag__red {
background-color:$lt-background-color;
.flag {
border-radius: 1rem;
display: inline-block;
font-size: 0.9rem;
@ -7,25 +6,19 @@
margin: 0.5rem 0.75rem 0.25rem 0;
padding: 0.45rem 0.65rem;
text-transform: lowercase;
&:before {
@include icon__avoid();
@include icon__embed();
&--red {
background-color:$lt-background-color;
&:before {
@include icon__avoid();
@include icon__embed();
}
}
}
.flag__yellow {
background-color: $lt-background-color-warning;
border-radius: 1rem;
display: inline-block;
font-size: 0.9rem;
font-weight: bold;
margin: 0.5rem 0.75rem 0.25rem 0;
padding: 0.45rem 0.65rem;
text-transform: lowercase;
&:before {
@include icon__warning();
@include icon__embed();
&--yellow {
background-color: $lt-background-color-warning;
&:before {
@include icon__warning();
@include icon__embed();
}
}
}
}